LadyForest commented on code in PR #21771: URL: https://github.com/apache/flink/pull/21771#discussion_r1090258318
########## flink-table/flink-sql-client/src/test/resources/sql/set.q: ########## @@ -118,14 +118,13 @@ SELECT hive_add_one(1); Received a total of 1 row !ok -# TODO: support this in the FLINK-30692 -#REMOVE JAR '$VAR_UDF_JAR_PATH'; -#[INFO] The specified jar is removed from session classloader. -#!info +REMOVE JAR '$VAR_UDF_JAR_PATH'; Review Comment: Nit: add `SHOW JARS` before and after `REMOVE JAR`? ########## flink-table/flink-sql-client/src/test/resources/sql/set.q: ########## @@ -313,3 +303,11 @@ SELECT id, func1(str) FROM (VALUES (1, 'Hello World')) AS T(id, str) ; +----+-------------+--------------------------------+ Received a total of 1 row !ok + +REMOVE JAR '$VAR_UDF_JAR_PATH'; Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
