zentol commented on code in PR #597:
URL: https://github.com/apache/flink-web/pull/597#discussion_r1088741118
##########
docs/static/generated/rest_v1_dispatcher.yml:
##########
@@ -0,0 +1,2907 @@
+openapi: 3.0.1
+info:
+ title: Flink JobManager REST API
Review Comment:
This doesn't belong here.
##########
docs/build_docs.sh:
##########
@@ -18,29 +17,12 @@
# limitations under the License.
################################################################################
+if ! command -v hugo &> /dev/null
+then
Review Comment:
It would be nice if this could be in the root directory.
Also, the previous build.sh/docker-build.sh scripts should be replaced.
##########
content/q/gradle-quickstart.sh:
##########
@@ -1,250 +0,0 @@
-#!/bin/bash
-
-################################################################################
Review Comment:
So are we just removing the quickstarts?
##########
docs/layouts/shortcodes/table.html:
##########
@@ -0,0 +1,322 @@
+{{/*
+https://github.com/pablotron/hugo-shortcode-table
+
+Custom Hugo table shortcode which renders tables by:
+
+1. Reading table definition and data from the front matter or
+site data directory.
+2. Renders the table using CSS classes rather than inline styles.
+
+Why does this shortcode exist?
+
+1. The default Markdown table markup in Hugo is horrible for anything
+more than rudimentary tables.
+2. The default Markdown table renderer in Hugo does not give you a way
+to set cell alignment without using inline styles, which means
+enabling `unsafe-inline` in your `Content-Security-Policy` header.
+3. I prever specifying table contents in an external structured file
Review Comment:
```suggestion
3. I prefer specifying table contents in an external structured file
```
Maybe also remove references to "I". Who this is referring to will become
unclear over time.
##########
content/img/blog/2023-01-20-delegation-token-framework/delegation_token_framework.svg:
##########
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-<!-- Do not edit this file with editors other than diagrams.net -->
-<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd";>
Review Comment:
Probably accidentally deleted due to being a new blogpost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
