zhuzhurk commented on code in PR #21772:
URL: https://github.com/apache/flink/pull/21772#discussion_r1090405433
##########
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java:
##########
@@ -591,6 +605,9 @@ public void postVisit(PlanNode node) {
.addOutputShipStrategy(ShipStrategyType.FORWARD);
}
chainedTask.setContainingVertex(container);
+ if (!parallelismConfigured) {
Review Comment:
```suggestion
if (!node.isParallelismConfigured()) {
```
And remove the above `parallelismConfigured`.
##########
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/GraphCreatingVisitor.java:
##########
@@ -241,17 +241,19 @@ public boolean preVisit(Operator<?> c) {
// Keep parallelism of union undefined for now.
// It will be determined based on the parallelism of its
successor.
par = -1;
+ n.setParallelismConfigured(false);
} else if (par > 0) {
if (this.forceParallelism && par != this.defaultParallelism) {
par = this.defaultParallelism;
+ n.setParallelismConfigured(false);
Review Comment:
This is a forced parallelism and should not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
