snuyanzin commented on PR #21768: URL: https://github.com/apache/flink/pull/21768#issuecomment-1409844921
Looks good from my side checked that there is no junit4 related classes or packages in changed packages. One tiny things (probably not directly related): there is `org.apache.flink.runtime.leaderretrieval.ZooKeeperLeaderRetrievalTest#testConnectingAddressRetrievalWithDelayedLeaderElection` do you think it make sense to put initialization of `ServerSocket` in `try...resources`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
