zentol commented on code in PR #21798:
URL: https://github.com/apache/flink/pull/21798#discussion_r1091647908
##########
flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryInputStreamDeserializer.java:
##########
@@ -73,12 +72,10 @@ public Schema getSchemaAndDeserializedStream(InputStream
in) throws IOException
in.read(inputBytes);
in.reset();
- MutableByteArrayInputStream mutableByteArrayInputStream =
(MutableByteArrayInputStream) in;
String schemaDefinition =
glueSchemaRegistryDeserializationFacade.getSchemaDefinition(inputBytes);
byte[] deserializedBytes =
glueSchemaRegistryDeserializationFacade.getActualData(inputBytes);
Review Comment:
This is now unused
##########
flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryInputStreamDeserializer.java:
##########
@@ -73,12 +72,10 @@ public Schema getSchemaAndDeserializedStream(InputStream
in) throws IOException
in.read(inputBytes);
in.reset();
- MutableByteArrayInputStream mutableByteArrayInputStream =
(MutableByteArrayInputStream) in;
String schemaDefinition =
glueSchemaRegistryDeserializationFacade.getSchemaDefinition(inputBytes);
byte[] deserializedBytes =
glueSchemaRegistryDeserializationFacade.getActualData(inputBytes);
- mutableByteArrayInputStream.setBuffer(deserializedBytes);
Review Comment:
What was this actually doing? AFAICT, nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
