rkhachatryan commented on code in PR #21778:
URL: https://github.com/apache/flink/pull/21778#discussion_r1091787481
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackend.java:
##########
@@ -298,6 +303,11 @@ private EmbeddedRocksDBStateBackend(
checkArgument(
overlapFractionThreshold >= 0 && this.overlapFractionThreshold
<= 1,
"Overlap fraction threshold of restoring should be between 0
and 1");
+
+ this.rocksDBMemoryFactory =
Review Comment:
I was concerned about deserialization. Because the field isn't `final`,
initialization in the default constructor is optional, so it might break in the
future.
But ATM it can't be null. I'll remove the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]