Myasuka commented on code in PR #18523:
URL: https://github.com/apache/flink/pull/18523#discussion_r1091874874
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonPlanGenerator.java:
##########
@@ -117,10 +118,27 @@ public static String generatePlan(
// write the core properties
JobVertexID vertexID = vertex.getID();
int storeParallelism =
vertexParallelism.getParallelism(vertexID);
+ int parallelism =
+ storeParallelism != -1 ? storeParallelism :
vertex.getParallelism();
gen.writeStringField("id", vertexID.toString());
- gen.writeNumberField(
- "parallelism",
- storeParallelism != -1 ? storeParallelism :
vertex.getParallelism());
+ gen.writeNumberField("parallelism", parallelism);
+ int storeMaxParallelism =
+ vertexParallelism.getMaxParallelismForVertices() ==
null
+ ? -1
+ : vertexParallelism
+ .getMaxParallelismForVertices()
+ .getOrDefault(vertexID, -1);
+ int maxParallelism =
+ storeMaxParallelism == -1
Review Comment:
Too many `-1` here, we should use `JobVertex#MAX_PARALLELISM_DEFAULT` to
improve human readability.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonPlanGenerator.java:
##########
@@ -117,10 +118,27 @@ public static String generatePlan(
// write the core properties
JobVertexID vertexID = vertex.getID();
int storeParallelism =
vertexParallelism.getParallelism(vertexID);
+ int parallelism =
+ storeParallelism != -1 ? storeParallelism :
vertex.getParallelism();
gen.writeStringField("id", vertexID.toString());
- gen.writeNumberField(
- "parallelism",
- storeParallelism != -1 ? storeParallelism :
vertex.getParallelism());
+ gen.writeNumberField("parallelism", parallelism);
+ int storeMaxParallelism =
+ vertexParallelism.getMaxParallelismForVertices() ==
null
Review Comment:
`VertexParallelism#getMaxParallelismForVertices` shall not return `null`,
you can add `@Nonnull` to the interface method signature with javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
