twalthr commented on code in PR #21808:
URL: https://github.com/apache/flink/pull/21808#discussion_r1092114325
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java:
##########
@@ -240,6 +246,76 @@ public void
testKafkaSourceSinkWithBoundedSpecificOffsets() throws Exception {
deleteTestTopic(topic);
}
+ @Test
+ public void testKafkaSourceSinkWithBoundedTimestamp() throws Exception {
+ // we always use a different topic name for each parameterized topic,
+ // in order to make sure the topic can be created.
+ final String topic = "bounded_" + format + "_" + UUID.randomUUID();
+ createTestTopic(topic, 1, 1);
+
+ // ---------- Produce an event time stream into Kafka
-------------------
+ String groupId = getStandardProps().getProperty("group.id");
+ String bootstraps = getBootstrapServers();
+
+ final String createTable =
+ String.format(
+ "CREATE TABLE kafka (\n"
+ + " `user_id` INT,\n"
+ + " `item_id` INT,\n"
+ + " `behavior` STRING,\n"
+ + " `event_time` TIMESTAMP(3) METADATA FROM
'timestamp'"
Review Comment:
Why don't you use `TIMESTAMP_LTZ(3)` here? This would avoid a later
`LocalDateTime.ofInstant(Instant.ofEpochMilli(0L), ZoneId.systemDefault())`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
