[ 
https://issues.apache.org/jira/browse/FLINK-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562131#comment-15562131
 ] 

ASF GitHub Bot commented on FLINK-4771:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2612#discussion_r82590712
  
    --- Diff: 
flink-batch-connectors/flink-avro/src/test/java/org/apache/flink/api/java/io/AvroOutputFormatTest.java
 ---
    @@ -0,0 +1,106 @@
    +package org.apache.flink.api.java.io;
    +
    +import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
    +
    +import java.io.IOException;
    +import java.net.URISyntaxException;
    +import java.nio.file.Files;
    +import java.nio.file.Paths;
    +
    +import org.apache.avro.file.CodecFactory;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.FileSystem;
    +import org.apache.flink.core.fs.Path;
    +import org.junit.Test;
    +
    +/**
    + * Tests for {@link AvroOutputFormat}
    + */
    +public class AvroOutputFormatTest {
    +
    +    @Test
    +    public void testSetCodecFactory() throws Exception {
    +        // given
    +        final AvroOutputFormat<DummyAvroType> outputFormat = new 
AvroOutputFormat<>(DummyAvroType.class);
    +
    +        // when
    +        try {
    +            outputFormat.setCodecFactory(CodecFactory.snappyCodec());
    +        } catch (Exception ex) {
    +            // then
    +            fail("unexpected exception");
    +        }
    +    }
    +
    +    @Test
    +    public void testSetCodecFactoryError() throws Exception {
    +        // given
    +        boolean error = false;
    +        final AvroOutputFormat<DummyAvroType> outputFormat = new 
AvroOutputFormat<>(DummyAvroType.class);
    +
    +        // when
    +        try {
    +            outputFormat.setCodecFactory(null);
    +        } catch (Exception ex) {
    +            error = true;
    +        }
    +
    +        // then
    +        assertTrue(error);
    +    }
    +
    +    @Test
    +    public void testCompression() throws Exception {
    +        // given
    +        final Path outputPath = path("avro-output-file.avro");
    --- End diff --
    
    Please remove the files after the test was executed.


> Compression for AvroOutputFormat
> --------------------------------
>
>                 Key: FLINK-4771
>                 URL: https://issues.apache.org/jira/browse/FLINK-4771
>             Project: Flink
>          Issue Type: Improvement
>          Components: Batch Connectors and Input/Output Formats
>            Reporter: Lars Bachmann
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Currently it is not possible to set a compression codec for the 
> AvroOutputFormat. 
> This improvement will provide a setter for the avro CodecFactory which is 
> used by the DataFileWriter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to