JingGe commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1093000916
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java:
##########
@@ -54,11 +55,13 @@ private SqlClientOptions() {}
// Display options
- @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ @Deprecated
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
Review Comment:
It is really difficult to use cross modules ConfigOptions and keep them
synchronized. There are options:
option 1: use SqlConfigOption#DISPLAY_MAX_COLUMN_WIDTH as the fallback key
of TableConfigOption#DISPLAY_MAX_COLUMN_WIDTH. This does not work because
flink-table-api-java does not depends on flink-sql. Adding new dependency will
trigger a cycle dependency issue.
option 2: use TableConfigOption#DISPLAY_MAX_COLUMN_WIDTH as the fallback key
of SQLConfigOption#DISPLAY_MAX_COLUMN_WIDTH. If ResultDescriptor uses
TableConfigOption#DISPLAY_MAX_COLUMN_WIDTH, any change of
sql-client.display.max-column-width will not be able to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
