wuchong commented on code in PR #21322:
URL: https://github.com/apache/flink/pull/21322#discussion_r1093028337
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableConfigTest.java:
##########
@@ -122,4 +124,14 @@ void testSetAndGetIdleStateRetention() {
assertThat(CONFIG_BY_METHOD.getIdleStateRetention()).isEqualTo(Duration.ofHours(1));
assertThat(CONFIG_BY_CONFIGURATION.getIdleStateRetention()).isEqualTo(Duration.ofHours(1));
}
+ @Test
Review Comment:
Add empty line.
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/SqlClientOptions.java:
##########
@@ -54,16 +54,18 @@ private SqlClientOptions() {}
"Determine whether to output the verbose output to
the console. If set the option true, it will print the exception stack.
Otherwise, it only output the cause.");
// Display options
-
- @Deprecated
+ /**
+ * Deprecated. Please use {@link
TableConfigOptions#DISPLAY_MAX_COLUMN_WIDTH} instead.
+ * Please refer to FLINK-30862 for the reason that no @Deprecated has been
used
+ */
@Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
public static final ConfigOption<Integer> DISPLAY_MAX_COLUMN_WIDTH =
ConfigOptions.key("sql-client.display.max-column-width")
.intType()
.defaultValue(30)
.withFallbackKeys(TableConfigOptions.DISPLAY_MAX_COLUMN_WIDTH.key())
.withDescription(
- "When printing the query results, this parameter
determines the number of characters shown on screen before truncating."
- + "This only applies to columns with
variable-length types (e.g. STRING) in streaming mode."
- + "Fixed-length types and all types in
batch mode are printed using a deterministic column width");
+ "@Deprecated: when printing the query results,
this parameter determines the number of characters shown on screen before
truncating. "
Review Comment:
Would be better to mention the recommended configuration be mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
