dawidwys commented on code in PR #21594:
URL: https://github.com/apache/flink/pull/21594#discussion_r1093094007
##########
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java:
##########
@@ -193,7 +195,8 @@ void testSpecificType() throws Exception {
ROW(
FIELD("type_timestamp_millis",
TIMESTAMP(3).notNull()),
FIELD("type_date", DATE().notNull()),
- FIELD("type_time_millis", TIME(3).notNull()))
+ FIELD("type_time_millis", TIME(3).notNull()),
+ FIELD("type_local_timestamp_millis",
TIMESTAMP(3).notNull()))
Review Comment:
Moreover you do not assert anything here. Please add an assertion for the
timestamp:
```
assertThat(new
DataFormatConverters.LocalDateTimeConverter(3).toExternal(rowData, 3))
.isEqualTo(localDateTime);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
