zhuzhurk commented on code in PR #21814:
URL: https://github.com/apache/flink/pull/21814#discussion_r1093198187


##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/DefaultSlotPoolServiceSchedulerFactoryTest.java:
##########
@@ -96,4 +148,16 @@ private static Stream<Arguments> 
testGetRequestSlotMatchingStrategy() {
                         JobType.STREAMING,
                         
PreferredAllocationRequestSlotMatchingStrategy.INSTANCE));
     }
+
+    private String saveAdaptiveSchedulerTestPropertyValue() {
+        return (String) 
System.getProperties().remove("flink.tests.enable-adaptive-scheduler");

Review Comment:
   I would not remove it here but explicitly remove it in 
`testFallBackSchedulerWithoutAdaptiveSchedulerTestProperty`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to