zlzhang0122 commented on code in PR #18523:
URL: https://github.com/apache/flink/pull/18523#discussion_r1093984069
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultExecutionGraphFactory.java:
##########
@@ -197,9 +199,23 @@ public ExecutionGraph createAndRestoreExecutionGraph(
// check whether we can restore from a savepoint
tryRestoreExecutionGraphFromSavepoint(
newExecutionGraph,
jobGraph.getSavepointRestoreSettings());
+
+ for (JobVertex jobVertex : jobGraph.getVertices()) {
+ int maxParallelism =
+ newExecutionGraph
+ .getAllVertices()
+ .get(jobVertex.getID())
+ .getMaxParallelism();
+
+ jobVertex.setMaxParallelism(maxParallelism);
+ }
}
}
+ // set the basic properties
+
+
newExecutionGraph.setJsonPlan(JsonPlanGenerator.generatePlan(jobGraph));
Review Comment:
@Myasuka Yes, we can and I quite agree with you. The only thing I'm not sure
with is we should generate the json plan again to change it or we should get
the default json plan and just change the maxParallelism? The second choice is
more reasonable but parse and change the json plan maybe more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]