[
https://issues.apache.org/jira/browse/FLINK-30833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683285#comment-17683285
]
Qingsheng Ren commented on FLINK-30833:
---------------------------------------
[~mason6345] Please go ahead as it's just a test utilization, but I'm afraid I
don't quite get the motivation of the improvement. The original purpose of
creating {{MetricListener}} is to trap metrics registered under a group and
check if their values are as expected (Mainly used for testing connector
metrics but of course it's a general one). Could you elaborate more about
"closing metric groups"? I assume this is not relevant to
{{{}MetricListener{}}}.
> MetricListener supports closing metric groups
> ---------------------------------------------
>
> Key: FLINK-30833
> URL: https://issues.apache.org/jira/browse/FLINK-30833
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics, Tests
> Affects Versions: 1.16.1
> Reporter: Mason Chen
> Priority: Major
>
> The internal TestingMetricRegistry does not register an action when a metric
> group is closed. This would allow the use of the MetricListener to test logic
> that closes metric groups.
> [https://github.com/apache/flink/blob/44dbb8ec84792540095b826616d0f21b745aa995/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/metrics/testutils/MetricListener.java#L53]
> This change doesn't require exposing any public API and is transparent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
