lincoln-lil commented on code in PR #21800:
URL: https://github.com/apache/flink/pull/21800#discussion_r1094433098
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ExecutorImpl.java:
##########
@@ -265,9 +256,13 @@ public List<String> completeStatement(String statement,
int position) {
@Override
public void close() {
- closeSession();
- executorService.shutdownNow();
- heartbeatScheduler.shutdownNow();
+ if (!registry.isClosed()) {
+ try {
+ registry.close();
+ } catch (Throwable t) {
+ // ignore
Review Comment:
nit: we'd better log the suppressed exception though it will not cause
failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
