[
https://issues.apache.org/jira/browse/FLINK-29038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683732#comment-17683732
]
Matthias Pohl commented on FLINK-29038:
---------------------------------------
[~lincoln.86xy]: I didn't check the fix earlier. I did a pass over it now: The
test class itself doesn't follow Flink's coding guidelines in terms of timeouts
which leaves it vulnerable to test instabilities. We agreed on not using
timeouts in tests and let the be shutdown by the test watchdog process which
will print a thread dump at the end (see [coding
guidelines|https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests]).
If we really have an issue with tests running into timeouts, printing the
thread dump in the end might help investigating the issue in comparison to
letting the test fail early. I feel like using the 10s deadline in
[AsyncWaitOperatorTest:1242|https://github.com/apache/flink/blob/a1d74c131b0fd10f34436463077fd5c7a7984a2b/flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java#L1242]
is not necessary. The same applies to other tests in this class where we use
timeouts.
> AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteOrderedWithRetry
> failed with AssertionError
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-29038
> URL: https://issues.apache.org/jira/browse/FLINK-29038
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream
> Affects Versions: 1.16.0, 1.17.0
> Reporter: Huang Xingbo
> Assignee: lincoln lee
> Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.16.0
>
>
> {code:java}
> 2022-08-18T15:58:28.8029934Z Aug 18 15:58:28 [INFO] Results:
> 2022-08-18T15:58:28.8030287Z Aug 18 15:58:28 [INFO]
> 2022-08-18T15:58:28.8030644Z Aug 18 15:58:28 [ERROR] Failures:
> 2022-08-18T15:58:28.8032800Z Aug 18 15:58:28 [ERROR]
> AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteOrderedWithRetry:1203->testProcessingTimeWithRetry:1253
> ORDERED Output was not correct.: array lengths differed, expected.length=3
> actual.length=2; arrays first differed at element [2]; expected:<Record @ 6 :
> 12> but was:<end of array>
> 2022-08-18T15:58:28.8033826Z Aug 18 15:58:28 [INFO]
> 2022-08-18T15:58:28.8034265Z Aug 18 15:58:28 [ERROR] Tests run: 2061,
> Failures: 1, Errors: 0, Skipped: 28
> {code}
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=40164&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
