karthitect commented on code in PR #52:
URL: 
https://github.com/apache/flink-connector-aws/pull/52#discussion_r1096011540


##########
flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java:
##########
@@ -242,6 +244,8 @@ public FlinkKinesisConsumer(
                     "Flink Kinesis Consumer is going to read the following 
streams: {}",
                     sb.toString());
         }
+
+        this.shardAssigner = createShardAssigner();

Review Comment:
   I think that's a great suggestion. Are there any other aspects of this 
connector (or any others) that are extensible in this way? Other than the 
connectors themselves? Hoping to emulate if such a thing already exists... 
Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to