zhuzhurk commented on code in PR #21857:
URL: https://github.com/apache/flink/pull/21857#discussion_r1097110231


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java:
##########
@@ -469,4 +469,16 @@ static DefaultVertexParallelismAndInputInfosDecider 
from(Configuration configura
                         BatchExecutionOptions
                                 
.ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM));
     }
+
+    static int getDefaultMaxParallelism(Configuration configuration) {
+        return configuration
+                
.getOptional(BatchExecutionOptions.ADAPTIVE_AUTO_PARALLELISM_MAX_PARALLELISM)
+                .orElse(
+                        configuration
+                                .getOptional(CoreOptions.DEFAULT_PARALLELISM)

Review Comment:
   I think it should fall back to  `ExecutionConfig#parallelism` instead of the 
configuration `CoreOptions.DEFAULT_PARALLELISM`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to