zch93 commented on code in PR #524:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/524#discussion_r1097894933
##########
helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml:
##########
@@ -9243,6 +9242,19 @@ spec:
type: object
error:
type: string
+ lifecycleState:
+ enum:
+ - CREATED
+ - SUSPENDED
+ - UPGRADING
+ - DEPLOYED
+ - STABLE
+ - ROLLING_BACK
+ - ROLLED_BACK
+ - FAILED
+ - terminal
Review Comment:
For some reason the fabric8 crd gen includes all the fields from the
`ResourceLifecycleState`, and this is why `terminal` and `description` also
appear. This is not good I agree, maybe some annotation needed above those
fields to ignore those by the crd generator. I can take a look at those
tomorrow afternoon (CET). However, maybe that is not required to commit the
automated generated yaml files, am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
