zhipeng93 commented on code in PR #205:
URL: https://github.com/apache/flink-ml/pull/205#discussion_r1098259151
##########
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/stringindexer/StringIndexerTest.java:
##########
@@ -53,6 +55,9 @@ public class StringIndexerTest extends AbstractTestBase {
private Table trainTable;
private Table predictTable;
+ private Table trainTableWithNull;
Review Comment:
Thanks for the PR. The fix looks good to me. One minor question: Can you
simplify the test by adding null values in `trainTable` and `predictTable`? In
this case, the test case would be simpler. And it would be great if we also
update the python test.
##########
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/stringindexer/StringIndexerTest.java:
##########
@@ -53,6 +55,9 @@ public class StringIndexerTest extends AbstractTestBase {
private Table trainTable;
private Table predictTable;
+ private Table trainTableWithNull;
Review Comment:
Thanks for the PR. The fix looks good to me.
One minor question: Can you simplify the test by adding null values in
`trainTable` and `predictTable`? In this case, the test case would be simpler.
And it would be great if we also update the python test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
