XComp commented on code in PR #18893:
URL: https://github.com/apache/flink/pull/18893#discussion_r1098360662
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableITCase.scala:
##########
@@ -124,16 +124,22 @@ class TableITCase(tableEnvName: String, isStreaming:
Boolean) extends AbstractTe
assertEquals(ResultKind.SUCCESS_WITH_CONTENT, tableResult.getResultKind)
val it = tableResult.collect()
it.close()
- val jobStatus = try {
- Some(tableResult.getJobClient.get().getJobStatus.get())
- } catch {
- // ignore the exception,
- // because the MiniCluster maybe already been shut down when getting job
status
- case _: Throwable => None
- }
- if (jobStatus.isDefined) {
- assertNotEquals(JobStatus.RUNNING, jobStatus.get)
+
+ val numRetries = 7
Review Comment:
That shouldn't be an issue, @tsreaper. The Flink community agreed on leaving
JUnit tests to run forever in the worst case (see [Flink's coding convention on
this
matter](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests)).
There's a watchdog process running that will kill the test run after a certain
amount of time (4hrs right now as far as I remember). The benefit of this
approach is that this will print the thread dump which might help investigating
why a test ran into a dead-/livelock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
