zentol commented on code in PR #21869:
URL: https://github.com/apache/flink/pull/21869#discussion_r1098395674
##########
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java:
##########
@@ -348,6 +351,11 @@ void testApplicationIsStoppedWhenStoppingBootstrap()
throws Exception {
bootstrap.stop();
+ // Triggers the scheduled ApplicationDispatcherBootstrap process after
calling stop. This
+ // ensures that the bootstrap task isn't completed before the stop
method is called which
+ // would prevent the stop call from cancelling the task's future.
+ manuallyTriggeredExecutor.triggerNonPeriodicScheduledTask();
Review Comment:
hmm. I guess this is fine, but my impression is that the manual executor
relies more on implementation details than delaying the job submission would.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
