eskabetxe commented on code in PR #18: URL: https://github.com/apache/flink-connector-jdbc/pull/18#discussion_r1098401398
########## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/JdbcDialectTypeTest.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.dialect; + +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; + +import org.junit.jupiter.api.TestInstance; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +import javax.annotation.Nullable; + +import java.util.Arrays; +import java.util.List; + +import static org.apache.flink.core.testutils.FlinkAssertions.anyCauseMatches; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +/** Tests for all DataTypes and Dialects of JDBC connector. */ +@TestInstance(TestInstance.Lifecycle.PER_CLASS) +public class JdbcDialectTypeTest { + + private static final String DDL_FORMAT = + "CREATE TABLE T (f0 %s)" + + " WITH (" + + " 'connector'='jdbc'," + + " 'url'='jdbc:%s:memory:test'," + + " 'table-name'='myTable'" + + ")"; + + protected String testDialect() { + return "derby"; + } Review Comment: derby Its the default database in all tests.. Some of the problems we have (and in next fase of this task will be address) its that we finish copying the tests to other databases and we should extend the test (I think) the only thing that should change its the database container, and table creation.. but, we could have a lot of base tests, and implement on each database all the tests.. I think that its better the other way, that all test are derby and overriding when necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
