ruanhang1993 commented on code in PR #21589:
URL: https://github.com/apache/flink/pull/21589#discussion_r1099804063
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java:
##########
@@ -479,6 +486,125 @@ public void testSupportsPausingOrResumingSplits() throws
Exception {
}
}
+ @Test
+ public void testSupportsUsingRecordEvaluatorWithSplitsFinishedAtMiddle()
throws Exception {
+ final Set<String> finishedSplits = new HashSet<>();
+ try (final KafkaSourceReader<Integer> reader =
+ (KafkaSourceReader<Integer>)
+ createReader(
+ Boundedness.BOUNDED,
+ "groupId",
+ new TestingReaderContext(),
+ finishedSplits::addAll,
+ r -> r == 7 || r == NUM_RECORDS_PER_SPLIT +
5)) {
+ KafkaPartitionSplit split1 =
+ new KafkaPartitionSplit(new TopicPartition(TOPIC, 0), 0,
Integer.MAX_VALUE);
+ KafkaPartitionSplit split2 =
+ new KafkaPartitionSplit(new TopicPartition(TOPIC, 1), 0,
Integer.MAX_VALUE);
+ reader.addSplits(Arrays.asList(split1, split2));
+ reader.notifyNoMoreSplits();
+
+ TestingReaderOutput<Integer> output = new TestingReaderOutput<>();
+ pollUntil(
+ reader,
+ output,
+ () -> output.getEmittedRecords().size() == 14,
Review Comment:
I will change the condition.
But actually the source may consume some more records after the eof record.
But these records will not be sent to the sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
