tisonkun commented on code in PR #20:
URL:
https://github.com/apache/flink-connector-pulsar/pull/20#discussion_r1099882779
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/PulsarSinkOptions.java:
##########
@@ -137,12 +137,24 @@ private PulsarSinkOptions() {
.withDescription(
Description.builder()
.text(
- "The metrics from Pulsar Producer
are only exposed if you enable this option.")
+ "The metrics from Pulsar Producer
are only exposed if you enable this option. ")
.text(
"You should set the %s to a
positive value if you enable this option.",
code(PULSAR_STATS_INTERVAL_SECONDS.key()))
.build());
+ public static final ConfigOption<Boolean>
PULSAR_VALIDATE_SINK_MESSAGE_BYTES =
+ ConfigOptions.key(SINK_CONFIG_PREFIX + "validateSinkMessageBytes")
Review Comment:
Well. I notice that other schemas are already configured in
`createMessageBuilder` if non-null. This PR is for AUTO_PRODUCE_BYTES only and
no other schema validations remains unhandled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
