tsreaper commented on code in PR #18893:
URL: https://github.com/apache/flink/pull/18893#discussion_r1099972258
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableITCase.scala:
##########
@@ -119,17 +118,10 @@ class TableITCase(tableEnvName: String, isStreaming:
Boolean) extends AbstractTe
assertEquals(ResultKind.SUCCESS_WITH_CONTENT, tableResult.getResultKind)
val it = tableResult.collect()
it.close()
- val jobStatus =
- try {
- Some(tableResult.getJobClient.get().getJobStatus.get())
- } catch {
- // ignore the exception,
- // because the MiniCluster maybe already been shut down when getting
job status
- case _: Throwable => None
- }
- if (jobStatus.isDefined) {
- assertNotEquals(JobStatus.RUNNING, jobStatus.get)
- }
+
+ // wait for mini cluster to shut down
+ val jobId = tableResult.getJobClient.get().getJobID
+
AbstractTestBase.MINI_CLUSTER_RESOURCE.getClusterClient.requestJobResult(jobId).get()
Review Comment:
You're right. A bounded source is not suitable for this test. Let me change
it to an unbounded one and assert that the task is cancelled successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
