Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2608#discussion_r82781804
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -51,9 +57,11 @@
/** States of the different task groups belonging to this checkpoint */
private final Map<JobVertexID, TaskState> taskStates;
- /** Flag to indicate whether the completed checkpoint data should be
deleted when this
- * handle to the checkpoint is disposed */
- private final boolean deleteStateWhenDisposed;
+ /** Properties for this checkpoint. */
+ private final CheckpointProperties props;
+
+ /** External path if persisted checkpoint; <code>null</code> otherwise.
*/
+ private final String externalPath;
--- End diff --
Could the external path be part of the `CheckpointProperties`? The external
path could be an `Option<String>`. Then we would get around the null field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
