Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2622#discussion_r82810425
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -670,11 +684,13 @@ public void run() {
                                                throw new 
RuntimeException("Unknown type " + type);
                                }
     
    -                           if (returnValue != 0) {
    -                                   Assert.fail("The YARN session returned 
with non-null value=" + returnValue);
    +                           if (returnValue != this.expectedReturnValue) {
    +                                   Assert.fail("The YARN session returned 
with unexpected value=" + returnValue + " expected=" + expectedReturnValue);
    --- End diff --
    
    This check is duplicate because it is already performed in the `Runner`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to