mxm commented on code in PR #529: URL: https://github.com/apache/flink-kubernetes-operator/pull/529#discussion_r1103083946
########## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoscalerFactoryImpl.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.autoscaler; + +import org.apache.flink.kubernetes.operator.reconciler.deployment.JobAutoScaler; +import org.apache.flink.kubernetes.operator.reconciler.deployment.JobAutoScalerFactory; +import org.apache.flink.kubernetes.operator.utils.EventRecorder; + +import com.google.auto.service.AutoService; +import io.fabric8.kubernetes.client.KubernetesClient; + +/** + * Factory for loading JobAutoScalerImpl included in this module. This class will be dynamically + * instantiated by the main operator module. + */ +@AutoService(JobAutoScalerFactory.class) Review Comment: This is still required. All plugins have to declare a META-INF/service file which this annotation and the auto-service plugin does automatically. ########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ########## @@ -468,6 +468,16 @@ protected void setOwnerReference(CR owner, Configuration deployConfig) { KubernetesConfigOptions.JOB_MANAGER_OWNER_REFERENCE, List.of(ownerReference)); } + private JobAutoScaler loadJobAutoscaler() { + for (JobAutoScalerFactory factory : ServiceLoader.load(JobAutoScalerFactory.class)) { + LOG.info("Loading JobAutoScaler implementation: {}", factory.getClass().getName()); + return factory.create(kubernetesClient, eventRecorder); + } + LOG.info("No JobAutoscaler implementation found. Autoscaling is disabled."); + return new NoopJobAutoscaler(); Review Comment: See the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
