[
https://issues.apache.org/jira/browse/FLINK-31021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687738#comment-17687738
]
Benchao Li commented on FLINK-31021:
------------------------------------
[~xccui] Thanks for involving me.
I totally agree that the generated code should also be split because it will
hit some JIT optimization limitations when the code grows too large. Do we have
any issue tracking this?
I'm fine with both way:
- change flink-protobuf to do not use static methods
- change code-splitter to support static methods
> JavaCodeSplitter doesn't split static method properly
> -----------------------------------------------------
>
> Key: FLINK-31021
> URL: https://issues.apache.org/jira/browse/FLINK-31021
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.14.4, 1.15.3, 1.16.1
> Reporter: Xingcan Cui
> Priority: Minor
>
> The exception while compiling the generated source
> {code:java}
> cause=org.codehaus.commons.compiler.CompileException: Line 3383, Column 90:
> Instance method "default void
> org.apache.flink.formats.protobuf.deserialize.GeneratedProtoToRow_655d75db1cf943838f5500013edfba82.decodeImpl(foo.bar.LogData)"
> cannot be invoked in static context,{code}
> The original method header
> {code:java}
> public static RowData decode(foo.bar.LogData message){{code}
> The code after split
>
> {code:java}
> Line 3383: public static RowData decode(foo.bar.LogData message){
> decodeImpl(message); return decodeReturnValue$0; }
> Line 3384:
> Line 3385: void decodeImpl(foo.bar.LogData message) {{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
