JingsongLi commented on PR #526: URL: https://github.com/apache/flink-table-store/pull/526#issuecomment-1427449782
Thanks @FangYongs for the contribution. - `VisibleForTesting` looks good to me. - `Documentation` is introduced in https://github.com/apache/flink-table-store/pull/524 - `Internal` I think we don't need to introduce this one. It is meaningless, all classes are internal by default. We can just remove `@Internal`s. - `Public` and `Experimental`, we don't need to introduce these two, we don't have public api now. Maybe we will have different ideas in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
