pnowojski commented on code in PR #21503:
URL: https://github.com/apache/flink/pull/21503#discussion_r1104462237


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -417,7 +420,12 @@ protected StreamTask(
             this.asyncExceptionHandler = new 
StreamTaskAsyncExceptionHandler(environment);
 
             this.asyncOperationsThreadPool =
-                    Executors.newCachedThreadPool(
+                    new ThreadPoolExecutor(
+                            0,
+                            configuration.getMaxConcurrentCheckpoints() + 1,

Review Comment:
   nit: maybe add a comment explaining this value?
   > With maxConcurrentCheckpoints + 1 we more or less adhere to the 
maxConcurrentCheckpoints configuration, but allow for a small leeway with 
allowing for simultaneous N ongoing concurrent checkpoints and for example 
clean up of one aborted one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to