reswqa commented on PR #29:
URL:
https://github.com/apache/flink-connector-pulsar/pull/29#issuecomment-1431471615
@syhily Thanks for the contribution. As you can see in your description of
`Purpose of the change`, this PR seems to be doing two things. I haven't seen
the code changes yet, but I have a small suggestion before the review: If these
two things are relatively independent (separable), it is better to split them
into two commits. This will be more friendly to the reviewer and can maintain a
clearer commit history. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
