ASF GitHub Bot commented on FLINK-4801:

GitHub user twalthr opened a pull request:


    [FLINK-4801] [types] Input type inference is faulty with custom Tuples and 

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    This PR solves an issue with `TypeExtractor` logic separated into two 
methods `createTypeInfoFromInput` and `findCorrespodingInfo`. I merged the two 
methods into one and added a test for it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4801

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2625
commit 13eac8e823da2429b5dad304e8a442e79a53989a
Author: twalthr <twal...@apache.org>
Date:   2016-10-12T08:33:47Z

    [FLINK-4801] [types] Input type inference is faulty with custom Tuples and 


> Input type inference is faulty with custom Tuples and RichFunctions
> -------------------------------------------------------------------
>                 Key: FLINK-4801
>                 URL: https://issues.apache.org/jira/browse/FLINK-4801
>             Project: Flink
>          Issue Type: Bug
>          Components: Type Serialization System
>            Reporter: Timo Walther
>            Assignee: Timo Walther
> This issue has been discussed on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Type-problem-in-RichFlatMapFunction-when-using-GenericArray-type-td13929.html
> This returns the wrong type:
> {code}
>   public static class Foo<K> extends Tuple2<K[], K> {
>     public Foo() {
>     }
>     public Foo(K[] value0, K value1) {
>       super(value0, value1);
>     }
>   }
>     DataSource<Foo<T>> fooDataSource = env.fromElements(foo);
>     DataSet<Foo<T>> ds = fooDataSource.join(fooDataSource)
>       .where(field).equalTo(field)
>       .with(new RichFlatJoinFunction<Foo<T>, Foo<T>, Foo<T>>() {
>         @Override
>         public void join(Foo<T> first, Foo<T> second,
>           Collector<Foo<T>> out) throws Exception {
>           out.collect(first);
>         }
>       });
> {code}

This message was sent by Atlassian JIRA

Reply via email to