JingsongLi commented on code in PR #536: URL: https://github.com/apache/flink-table-store/pull/536#discussion_r1108387031
########## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ########## @@ -527,6 +535,17 @@ public double orcBloomFilterFpp() { return options.get(ORC_BLOOM_FILTER_FPP); } + public Map<Integer, String> fileCompressionPerLevel() { + Map<String, String> levelCompressions = options.get(FILE_COMPRESSION_PER_LEVEL); + if (null != levelCompressions) { + return levelCompressions.entrySet().stream() + .collect( + Collectors.toMap( + e -> Integer.valueOf(e.getKey()), Map.Entry::getValue)); + } + return null; Review Comment: Maybe we can return an empty `Map` to avoid `if (fileCompressionPerLevel != null)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org