ASF GitHub Bot commented on FLINK-4691:

Github user twalthr commented on a diff in the pull request:

    --- Diff: 
    @@ -0,0 +1,48 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.java.table.windows;
    +import org.apache.flink.api.table.SessionWindow;
    + * Helper class for creating a session window. Session windows are ideal 
for cases where the
    + * window boundaries need to adjust to the incoming data. In a session 
window it is possible to
    + * have windows that start at individual points in time for each key and 
that end once there has
    + * been a certain period of inactivity.
    + */
    +public class Session {
    --- End diff --
    Another reason was that for a Scala user it would be an additional import. 
By now, `import org.apache.flink.api.scala.table._` is enough for using the 
Table API. If I move it in the general table package, the user has to import it 
and cannot use the fluent API anymore.

> Add group-windows for streaming tables        
> ---------------------------------------
>                 Key: FLINK-4691
>                 URL: https://issues.apache.org/jira/browse/FLINK-4691
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
> Add Tumble, Slide, Session group-windows for streaming tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
> Implementation of group-windows on streaming tables. This includes 
> implementing the API of group-windows, the logical validation for 
> group-windows, and the definition of the “rowtime” and “systemtime” keywords. 
> Group-windows on batch tables won’t be initially supported and will throw an 
> exception.

This message was sent by Atlassian JIRA

Reply via email to