syhily opened a new pull request, #33:
URL: https://github.com/apache/flink-connector-pulsar/pull/33

   ## Purpose of the change
   
   The connector can subscribe the topics by using regular expression. But it 
can't use any simple regex like `some.*`. Any regex should in 
`tenant/namespace/regex` format. Since Pulsar support simple topic name which 
live under `public` tenant and `default` namespace. I think it's awesome to 
support same ability in regex subscription.
   
   ## Brief change log
   
   - Change the internal design of `TopicPatternSubscriber`. The regex will be 
convert into a full regex by using `TopicName`.
   
   There is [a known bug](https://github.com/apache/pulsar/issues/19316) in 
Pulsar 2.11.0. We can't subscribe the non-persistent topics by using regex now. 
We also create [a JIRA 
ticket](https://issues.apache.org/jira/browse/FLINK-31107) for tracking this 
bug.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `PulsarSubscriberTest.simpleTopicPatternSubscriber`
   - `PulsarSubscriberTest.topicPatternSubscriber`
   - `PulsarSubscriberTest.subscribeNonPartitionedTopicPattern`
   
   ## Significant changes
   
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [x] New feature has been introduced
       - If yes, how is this documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to