huwh commented on code in PR #21849:
URL: https://github.com/apache/flink/pull/21849#discussion_r1109420069
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1394,13 +1394,14 @@ private CompletableFuture<Void> waitForTerminatingJob(
throwable));
});
- return jobManagerTerminationFuture.thenAcceptAsync(
+ return FutureUtils.thenAcceptAsyncIfNotDone(
Review Comment:
There is also a chance to submit duplicates when jobManagerTerminationFuture
is not finished. Maybe we should introduce something like "Set\<JobID\>
submitAndWaitingTermiateJobs". The Job that JobManagerTerminationFuture is not
finished should be added, and deleted when the future is finished. Then we
should check it in Dispatcher#isDuplicateJob.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
