JingsongLi commented on code in PR #540:
URL: https://github.com/apache/flink-table-store/pull/540#discussion_r1109562277
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/types/DataTypeCasts.java:
##########
@@ -57,23 +57,31 @@ public final class DataTypeCasts {
private static final Map<DataTypeRoot, Set<DataTypeRoot>>
explicitCastingRules;
+ private static final Map<DataTypeRoot, Set<DataTypeRoot>>
compatibleCastingRules;
+
static {
implicitCastingRules = new HashMap<>();
explicitCastingRules = new HashMap<>();
+ compatibleCastingRules = new HashMap<>();
// identity casts
for (DataTypeRoot typeRoot : allTypes()) {
- castTo(typeRoot).implicitFrom(typeRoot).build();
+
castTo(typeRoot).implicitFrom(typeRoot).compatibleFrom(typeRoot).build();
Review Comment:
We can remove this here. We can add all cast to the following list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
