Aitozi commented on code in PR #21622:
URL: https://github.com/apache/flink/pull/21622#discussion_r1111276427
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/PartitionableSourceTest.scala:
##########
@@ -148,6 +148,16 @@ class PartitionableSourceTest(val sourceFetchPartitions:
Boolean, val useCatalog
"select name from PartitionableAndFilterableTable " +
"where part1 = 'A' and part2 > 1 and id > 1")
}
+
+ @Test
+ def testRandCondition(): Unit = {
+ util.verifyRelPlan("SELECT * FROM PartitionableTable WHERE rand(1) <
0.001")
+ }
+
+ @Test
+ def testRandCondition2(): Unit = {
+ util.verifyRelPlan("SELECT * FROM PartitionableTable WHERE rand(part2) <
0.001")
+ }
Review Comment:
I mainly follow the suggestion as here:
https://github.com/apache/flink/pull/12966#pullrequestreview-455454350
Added the test in the rule test
`PushPartitionIntoLegacyTableSourceScanRuleTest` and `PartitionableSourceTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
