zhuzhurk commented on code in PR #21962: URL: https://github.com/apache/flink/pull/21962#discussion_r1111759503
########## flink-connectors/flink-connector-hive/archunit-violations/26d337fc-45c4-4d03-a84a-6692c37fafbc: ########## @@ -46,6 +46,12 @@ org.apache.flink.connectors.hive.HiveTableSourceITCase does not satisfy: only on * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\ * reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule +org.apache.flink.connectors.hive.HiveTableSpeculativeSinkITCase does not satisfy: only one of the following predicates match: Review Comment: I think this change is not needed if the test declares `MiniClusterExtension`, see `HiveTableCompactSinkITCase`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
