[
https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691205#comment-17691205
]
Matthias Pohl commented on FLINK-31084:
---------------------------------------
{quote}
Matthias Pohl Hi, I have encountered a problem, and I would like to ask your
opinion. If kind is set as' sequence ', end is set as Integer.MAX_VALUE and
parallelism is set as
1,https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java#L117
will have a problem here.
{quote}
It looks like {{saveDivide}} is misused here. That is a separate issue and
should be handled in a separate Jira issue.
> DataGen sequence generator requires the definition of start/end values
> ----------------------------------------------------------------------
>
> Key: FLINK-31084
> URL: https://issues.apache.org/jira/browse/FLINK-31084
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Common
> Affects Versions: 1.17.0, 1.15.3, 1.16.1
> Reporter: Matthias Pohl
> Assignee: xzw0223
> Priority: Major
> Labels: pull-request-available, starter
>
> The [DataGen connector's
> parameters|https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/connectors/table/datagen/#connector-options]
> are not precisely documented: The start/end parameters are labeled as
> required for the sequence generator even though they are (see
> [SequenceGeneratorVisitor:85ff|https://github.com/apache/flink/blob/ef9ce854a3169014001f39e0d5908c703453f2b8/flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/SequenceGeneratorVisitor.java#L85]).
> But instead of updating the documentation, we should just come up with
> reasonable default values. As a user, I would expect the positive integer
> values to be returned starting from 0 if I don't specify anything here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
