LadyForest commented on code in PR #21974:
URL: https://github.com/apache/flink/pull/21974#discussion_r1112473495


##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java:
##########
@@ -142,11 +151,13 @@ public static DefaultContext load(
         FileSystem.initialize(
                 configuration, 
PluginUtils.createPluginManagerFromRootFolder(configuration));
 
-        if (discoverPythonDependency) {
-            dependencies = new ArrayList<>(dependencies);
-            dependencies.addAll(discoverPythonDependencies());
+        if (!discoverExecutionConfig) {

Review Comment:
   I felt that the naming `discoverExecutionConfig` is a little hard to 
understand, why this param can control the python dependency discovery.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to