fsk119 commented on code in PR #21901:
URL: https://github.com/apache/flink/pull/21901#discussion_r1112610449
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/DefaultContextUtils.java:
##########
@@ -51,12 +52,17 @@ public static DefaultContext
buildDefaultContext(CliOptions.EmbeddedCliOptions o
} else {
libDirs = Collections.emptyList();
}
- return DefaultContext.load(
- options.getPythonConfiguration(), discoverDependencies(jars,
libDirs), true);
+ Configuration pythonConfiguration = options.getPythonConfiguration();
+ pythonConfiguration.addAll(
+
ConfigurationUtils.createConfiguration(options.getSessionConfig()));
+ return DefaultContext.load(pythonConfiguration,
discoverDependencies(jars, libDirs), true);
Review Comment:
nit: the name is not very suitable here. How about sessionConfig here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
