lindong28 commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1113828872
########## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/defs/Split.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.gbt.defs; + +import org.apache.flink.api.common.typeinfo.TypeInfo; +import org.apache.flink.ml.common.gbt.typeinfo.SplitTypeInfoFactory; + +import org.eclipse.collections.impl.map.mutable.primitive.IntDoubleHashMap; + +import java.util.BitSet; + +/** Stores a split on a feature. */ Review Comment: Does this class represents the same logical concept as `org.apache.spark.mllib.tree.model.Split`? If yes, would it be more intuitive to move it to a package similar to Spark's package path instead of putting it under `gbt` package? Same for other classes added in this PR. It will be nice to make package of classes consistent with their concepts, i.e. the package includes `gbt` if and only if the concept of this class is specific to gbt. ########## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/defs/Split.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.gbt.defs; + +import org.apache.flink.api.common.typeinfo.TypeInfo; +import org.apache.flink.ml.common.gbt.typeinfo.SplitTypeInfoFactory; + +import org.eclipse.collections.impl.map.mutable.primitive.IntDoubleHashMap; + +import java.util.BitSet; + +/** Stores a split on a feature. */ Review Comment: Does this class represents the same logical concept as `org.apache.spark.mllib.tree.model.Split`? If yes, would it be more intuitive to move it to a package similar to Spark's package path instead of putting it under `gbt` package? Same for other classes added in this PR. It will be nice to make package of classes consistent with their concepts, e.g. the package includes `gbt` if and only if the concept of this class is specific to gbt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
