zhuzhurk commented on code in PR #21970:
URL: https://github.com/apache/flink/pull/21970#discussion_r1112513443
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##########
@@ -377,6 +377,10 @@ private void restartTasks(
final Set<ExecutionVertexID> verticesToRestart =
executionVertexVersioner.getUnmodifiedExecutionVertices(executionVertexVersions);
+ if (verticesToRestart.isEmpty()) {
+ return;
Review Comment:
I'm not entirely sure but a bit concerned is that Flink may take some
important actions in
`CheckpointCoordinator#restoreLatestCheckpointedStateInternal()` even if
`verticesToRestart` if empty, e.g. `invoking
OperatorCoordinator#resetToCheckpoint(...)`. These actions were always taken
previously, while are possible to be skipped after this change(when a global
failover and regional failover happen concurrently).
I haven't had the chance to examine it all over yet. It's appreciated if you
can also help to examine this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
