akalash commented on code in PR #21999:
URL: https://github.com/apache/flink/pull/21999#discussion_r1114577578


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -261,6 +261,12 @@
      */
     private volatile boolean isRunning;
 
+    /**
+     * Flag to mark the task "in operation", in which case check needs to be 
process the exceptions
+     * thrown in the initializing duration.
+     */
+    private volatile boolean isInitializing;

Review Comment:
   Hm, I see, I need to think about that. 
   Just in case, `StreamTask` and `ExecutionState` are different levels of 
abstraction and we don't have to keep them the same. We can do it but I'm not 
sure yet that it has any advantages. We should consider that `StreamTask` has 
two methods `init` and `restore` where `init` is part of `restore`. The 
`isInitializing` follows the `restore` but it says that it follows the 
`initialization` this  `initialization` is have nothing in common with `init` 
method but it relates to `ExecutionState` which relates to `Task` rather than 
`StreamTask`.
   So I hope you understand now why I am confused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to