gaoyunhaii commented on code in PR #21943:
URL: https://github.com/apache/flink/pull/21943#discussion_r1115275981
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -1314,13 +1314,12 @@ private void
completePendingCheckpoint(PendingCheckpoint pendingCheckpoint)
if (!props.isSavepoint()) {
lastSubsumed =
addCompletedCheckpointToStoreAndSubsumeOldest(
- checkpointId,
- completedCheckpoint,
-
pendingCheckpoint.getCheckpointPlan().getTasksToCommitTo());
+ checkpointId, completedCheckpoint,
pendingCheckpoint);
} else {
lastSubsumed = null;
}
+
pendingCheckpoint.getCompletionFuture().complete(completedCheckpoint);
Review Comment:
I have a small concern here current `CompleteExceptionally` is not in the
same level with the complete. In this case, there is risk that if we change
logic here, there might be case that the future is not done finally.
To not change the order of "complete future" -> "report the checkpoint", we
might also try marking the checkpoint in the catch block in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
