Samrat002 commented on code in PR #21770:
URL: https://github.com/apache/flink/pull/21770#discussion_r1115352901
##########
flink-python/src/main/java/org/apache/flink/python/env/AbstractPythonEnvironmentManager.java:
##########
@@ -166,6 +166,14 @@ public Map<String, String>
constructEnvironmentVariables(String baseDirectory)
constructFilesDirectory(env, baseDirectory);
+ if (this.dependencyInfo.getPythonPath() != null) {
+ List<String> configuredPythonPath = new ArrayList<>();
+ configuredPythonPath.add(this.dependencyInfo.getPythonPath());
+ appendToPythonPath(env, configuredPythonPath);
Review Comment:
This is already existing path. code executes append only operation, this
doesn't modifies any pre configured python/path related configs and does only
the append operation that user has configured
##########
flink-python/src/main/java/org/apache/flink/python/env/AbstractPythonEnvironmentManager.java:
##########
@@ -166,6 +166,14 @@ public Map<String, String>
constructEnvironmentVariables(String baseDirectory)
constructFilesDirectory(env, baseDirectory);
+ if (this.dependencyInfo.getPythonPath() != null) {
+ List<String> configuredPythonPath = new ArrayList<>();
+ configuredPythonPath.add(this.dependencyInfo.getPythonPath());
+ appendToPythonPath(env, configuredPythonPath);
Review Comment:
Ideally it should not affect path resolution on TM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
